refactor!: update to boilerplate mapco 6313#6
Conversation
|
Update build-and-push github workflow |
| import { tracingFactory } from './common/tracing.js'; | ||
| import { getConfig, initConfig } from './common/config.js'; | ||
|
|
||
| await initConfig(true); |
There was a problem hiding this comment.
Remove true arg from initConfig.
You'll need to work with config server.
There was a problem hiding this comment.
I think the schemas PR first needs to be merged first in order for this to work. No?
| # This file instructs Redocly's linter to ignore the rules contained for specific parts of your API. | ||
| # See https://redocly.com/docs/cli/ for more information. | ||
| packages/backend/openapi3.yaml: | ||
| boolean-parameter-prefixes: | ||
| - '#/paths/~1cooldown/get/parameters/4/name' |
There was a problem hiding this comment.
why are there 2 .redocly.lint-ignore.yaml files, one of them is redundant.
packages/backend/package.json
Outdated
| "@map-colonies/js-logger": "^2.0.0", | ||
| "@map-colonies/openapi-express-viewer": "^4.0.0", | ||
| "@map-colonies/read-pkg": "^1.0.0", | ||
| "@map-colonies/schemas": "https://ghatmpstorage.blob.core.windows.net/npm-packages/schemas-0c282bb6b722a00eb82e7791f94261b29a0d8d48.tgz", |
There was a problem hiding this comment.
I'm guessing this version is temporary?
There was a problem hiding this comment.
Yes, waiting for it to be merged
There was a problem hiding this comment.
I'm not sure if and how the release-please pipeline works in a monorepo, this should be validated with infra team
There was a problem hiding this comment.
extend @map-colonies/tsconfig/tsconfig-app and keep necessary changes
There was a problem hiding this comment.
extend @map-colonies/tsconfig/tsconfig-app and keep necessary changes
packages/common/package.json
Outdated
| "eslint": "^8.56.0", | ||
| "jest": "^29.5.0", | ||
| "jest-create-mock-instance": "^2.0.0", | ||
| "jest-html-reporters": "^3.1.4", |
There was a problem hiding this comment.
update eslint and jest deps, this is also true for all other monorepo packages.
packages/client/package.json
Outdated
| "http-status-codes": "^2.2.0", | ||
| "qs": "^6.11.2" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
make sure all environmental packages are upgraded - typescript, jest, etc.
|
|
||
| beforeAll(() => { | ||
| mockedRedis = createClient({}) as jest.Mocked<RedisClient>; | ||
| mockedRedis = redisMock.mockRedisClient as unknown as jest.Mocked<RedisClient>; |
There was a problem hiding this comment.
declare the imported mock as jest.Mocked<RedisClient> in the mocks dir instead of casting here, do this for all 3 mocks
packages/frontend/.eslintrc.json
Outdated
There was a problem hiding this comment.
this is problematic. Instead of configuring the whole package with ignores - locate where ignores are absolutely required and only ignore them there
3 participants
Related issues: MAPCO-6131
Closes: MAPCO-6131
Close this issue before completing the PR.